pytest_plugin: Add GIT_CONFIG_GLOBAL for child processes #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocesses why: GIT_CONFIG is excluded from child process environment by git what: - Add GIT_CONFIG_GLOBAL env var which IS inherited by child processes - Fixes submodule operations in strict build environments
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #513 +/- ##
=======================================
Coverage 53.48% 53.48%
=======================================
Files 38 38
Lines 5703 5704 +1
Branches 1062 1062
=======================================
+ Hits 3050 3051 +1
Misses 2143 2143
Partials 510 510 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GIT_CONFIG_GLOBALtoset_gitconfigfixturegit submodule add),GIT_CONFIGis explicitly excluded from the child environmentGIT_CONFIG_GLOBALIS inherited by child processes, fixing submodule operations in strict build environmentsFollow-up to #512 / v0.38.5 for #509
Test plan
test_git_repo_fixture_submodule_file_protocolpasses