-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(releases): improve commit categorization and ci security #2992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile OverviewGreptile SummaryThis PR addresses two important issues: Security fix: Prevented command injection vulnerability in CI workflow by passing commit message through environment variable ( Commit categorization improvement: Updated release script to prioritize conventional commit prefixes ( The changes improve both security posture and release note accuracy. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions
participant Script as create-single-release.ts
participant Git as Git Repository
participant GitHub as GitHub API
Note over GHA: CI Workflow (ci.yml)
GHA->>GHA: Trigger on push to main/staging
GHA->>GHA: Set COMMIT_MSG env var (secure)
GHA->>GHA: Check if COMMIT_MSG matches version pattern
alt Is release commit on main
GHA->>GHA: Extract version from commit message
GHA->>GHA: Set is_release=true
else Not a release
GHA->>GHA: Set is_release=false
end
Note over Script: Release Script Flow
Script->>Git: Find version commit
Git-->>Script: Return commit hash & metadata
Script->>Git: Find previous version commit
Git-->>Script: Return previous commit hash
Script->>Git: Get commits between versions
Git-->>Script: Return commit list
loop For each commit
Script->>GitHub: Fetch commit details via API
GitHub-->>Script: Return author, PR number
Script->>Script: Categorize commit (conventional format priority)
Note over Script: 1. Check conventional prefixes<br/>2. Check other standard prefixes<br/>3. Fall back to keyword matching
end
Script->>Script: Group commits by category
Script->>Script: Generate release notes body
Script->>GitHub: Create GitHub release
GitHub-->>Script: Release created successfully
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Summary
Type of Change
Testing
Tested manually
Checklist