Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • add tooltip to canonical toggle button

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 25, 2026 5:57am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 25, 2026

Greptile Overview

Greptile Summary

Wrapped the canonical toggle button with a Tooltip component to improve discoverability of the toggle functionality.

  • Added Tooltip.Root, Tooltip.Trigger, and Tooltip.Content following the existing pattern used for JSON validation warnings in the same file
  • Tooltip displays "Switch to selector" or "Switch to manual ID" based on current mode
  • Implementation follows EMCN component library patterns and imports from the correct path

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk
  • Simple UI enhancement that adds a tooltip to an existing button. The implementation follows established patterns in the codebase and only adds informational UI without changing any logic. Minor accessibility improvement suggested but not critical.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/sub-block.tsx Added tooltip to canonical toggle button following existing patterns, with minor accessibility inconsistency

Sequence Diagram

sequenceDiagram
    participant User
    participant Button as Canonical Toggle Button
    participant Tooltip as Tooltip Component
    participant Handler as canonicalToggle.onToggle

    User->>Button: Hover over button
    Button->>Tooltip: Trigger tooltip display
    Tooltip-->>User: Show "Switch to selector" or "Switch to manual ID"
    
    User->>Button: Click button
    Button->>Handler: Call onToggle()
    Handler-->>Button: Toggle mode (basic ↔ advanced)
    Button->>Tooltip: Update tooltip content based on new mode
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit 404d8c0 into staging Jan 25, 2026
7 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/tooltip branch January 25, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants