-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Set default layout.axis.tickmode to 'sync' when axis is overlaying
#7684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e7ee5b3 to
2be45e2
Compare
cb1bf35 to
c4c70fd
Compare
7230cfb to
7d71516
Compare
camdecoster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a few small syntax suggestions, but it's good to go as is.
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
0251716 to
79bf862
Compare
|
Hi @emilykl, |
|
@archmoj Thanks for the catch -- I've added a draftlog! It's a good point that this is a backward-incompatible change and so strictly speaking should only be introduced in a major version. I'm not psyched about bumping the version number just for this change, but perhaps there are a few other changes we could introduce at the same time. On the other hand, do you know if there are instances in the past where we've made an exception and introduced a change in a minor version? |
Closes #7683
This PR slightly modifies the default
tickmodelogic, such thattickmodedefaults to'sync'rather than'auto'for overlaying axes. Motivation is explained in the linked issue.Note: One case is excluded: When the overlaying axis is categorical (or multicategory), tickmode continues to default to
'auto'rather than'sync', as'sync'causes unexpected behavior with categorical axes and is probably never intended by the user.