Skip to content

Conversation

@emilykl
Copy link
Contributor

@emilykl emilykl commented Jan 6, 2026

Closes #7683

This PR slightly modifies the default tickmode logic, such that tickmode defaults to 'sync' rather than 'auto' for overlaying axes. Motivation is explained in the linked issue.

Note: One case is excluded: When the overlaying axis is categorical (or multicategory), tickmode continues to default to 'auto' rather than 'sync', as 'sync' causes unexpected behavior with categorical axes and is probably never intended by the user.

@emilykl emilykl force-pushed the shared-axis-lines-default branch from e7ee5b3 to 2be45e2 Compare January 7, 2026 21:29
@emilykl emilykl force-pushed the shared-axis-lines-default branch from cb1bf35 to c4c70fd Compare January 19, 2026 21:27
@emilykl emilykl force-pushed the shared-axis-lines-default branch from 7230cfb to 7d71516 Compare January 21, 2026 23:36
@emilykl emilykl requested a review from camdecoster January 21, 2026 23:56
Copy link
Contributor

@camdecoster camdecoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few small syntax suggestions, but it's good to go as is.

Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
@emilykl emilykl force-pushed the shared-axis-lines-default branch from 0251716 to 79bf862 Compare January 26, 2026 16:57
@archmoj
Copy link
Contributor

archmoj commented Jan 26, 2026

Hi @emilykl,
Thank you for the PR. Please note that the draftlog for this change is missing.
I'm wondering this PR could/should be considered a breaking change for v3.
If you are planning to release a major version, then this PR may belong to v4.
cc: @alexcjohnson

@emilykl
Copy link
Contributor Author

emilykl commented Jan 26, 2026

@archmoj Thanks for the catch -- I've added a draftlog!

It's a good point that this is a backward-incompatible change and so strictly speaking should only be introduced in a major version. I'm not psyched about bumping the version number just for this change, but perhaps there are a few other changes we could introduce at the same time. On the other hand, do you know if there are instances in the past where we've made an exception and introduced a change in a minor version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default gridline behavior for overlaid axes is ugly and hard to read

4 participants