Skip to content

Conversation

@laurenastrid1
Copy link
Contributor

@laurenastrid1 laurenastrid1 commented Jan 20, 2026

Pull Request Template – vscode-mssql

Description

backupDemoWithCloseAdded backup dialog

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5390 KB 5410 KB ⚪ 20 KB ( 0% )
sql-database-projects VSIX 5672 KB 5672 KB ⚪ 0 KB ( 0% )
data-workspace VSIX null KB 543 KB ⚪ 543 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 92.22222% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.51%. Comparing base (4a07f21) to head (2ed92e0).

Files with missing lines Patch % Lines
extensions/mssql/src/controllers/mainController.ts 21.05% 15 Missing ⚠️
...src/controllers/backupDatabaseWebviewController.ts 96.23% 11 Missing and 2 partials ⚠️
extensions/mssql/src/sharedInterfaces/backup.ts 88.46% 9 Missing ⚠️
extensions/mssql/src/services/backupService.ts 73.33% 4 Missing ⚠️
extensions/mssql/src/constants/locConstants.ts 98.41% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20939      +/-   ##
==========================================
+ Coverage   66.86%   67.51%   +0.64%     
==========================================
  Files         219      223       +4     
  Lines       20986    21526     +540     
  Branches     2750     2813      +63     
==========================================
+ Hits        14033    14534     +501     
- Misses       6852     6889      +37     
- Partials      101      103       +2     
Files with missing lines Coverage Δ
extensions/mssql/src/constants/constants.ts 100.00% <100.00%> (ø)
extensions/mssql/src/models/contracts/backup.ts 100.00% <100.00%> (ø)
extensions/mssql/src/services/sqlTasksService.ts 85.84% <100.00%> (+0.79%) ⬆️
extensions/mssql/src/sharedInterfaces/telemetry.ts 100.00% <100.00%> (ø)
extensions/mssql/src/constants/locConstants.ts 87.90% <98.41%> (+0.63%) ⬆️
extensions/mssql/src/services/backupService.ts 73.33% <73.33%> (ø)
extensions/mssql/src/sharedInterfaces/backup.ts 88.46% <88.46%> (ø)
...src/controllers/backupDatabaseWebviewController.ts 96.23% <96.23%> (ø)
extensions/mssql/src/controllers/mainController.ts 17.83% <21.05%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laurenastrid1 laurenastrid1 changed the title Laurenastrid1/backup Added backup dialog Jan 20, 2026
@aasimkhan30
Copy link
Contributor

I am also doing a framework for building object management dialogs and this does fit that pattern #20917

Let's try to merge the 2 branches so that we build something that's more consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants