-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Tweak prompt selection and also remind model to do all edits in a single tool call #3125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the Inline Chat V2 prompt to adjust how selection context is described and to steer the model toward completing edits in a single tool invocation, with corresponding simulation cache/outcome updates.
Changes:
- Adjusted Inline Chat V2 prompt instructions/reminders and selection messaging.
- Renamed the selection markup tag emitted by the inline prompt.
- Refreshed simulation artifacts (baseline/outcome JSONs) and added a new simulation cache layer.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/extension/prompts/node/inline/inlineChat2Prompt.tsx | Updates prompt instructions/reminders and selection markup emitted to the model. |
| test/simulation/cache/layers/0e97fa2a-7e18-41a8-bdfd-a9b65e0c4ac6.sqlite | Adds a new LFS-tracked simulation cache layer. |
| test/simulation/baseline.json | Updates simulation baseline pass/fail counts and scores after prompt changes. |
| test/outcome/generate-inlinechatintent-inline.json | Updates recorded request IDs for generate InlineChatIntent simulation outcomes. |
| test/outcome/fix-inlinechatintent-tsc-inline.json | Updates recorded request IDs for TSC fix InlineChatIntent simulation outcomes. |
| test/outcome/fix-inlinechatintent-ruff-inline.json | Updates recorded request IDs for Ruff fix InlineChatIntent simulation outcomes. |
| test/outcome/fix-inlinechatintent-roslyn-inline.json | Updates recorded request IDs for Roslyn fix InlineChatIntent simulation outcomes. |
| test/outcome/fix-inlinechatintent-pyright-inline.json | Updates recorded request IDs for Pyright fix InlineChatIntent simulation outcomes. |
| test/outcome/fix-inlinechatintent-pylint-inline.json | Updates recorded request IDs for Pylint fix InlineChatIntent simulation outcomes. |
| test/outcome/fix-inlinechatintent-powershell-inline.json | Updates recorded request IDs for PowerShell fix InlineChatIntent simulation outcomes. |
| test/outcome/fix-inlinechatintent-eslint-inline.json | Updates recorded request IDs for ESLint fix InlineChatIntent simulation outcomes. |
| test/outcome/fix-inlinechatintent-cpp-inline.json | Updates recorded request IDs for C++ fix InlineChatIntent simulation outcomes. |
| test/outcome/edit-inlinechatintent-inline.json | Updates recorded request IDs for edit InlineChatIntent simulation outcomes. |
Comments suppressed due to low confidence (1)
src/extension/prompts/node/inline/inlineChat2Prompt.tsx:83
- This reminder repeats the instruction to perform edits via
{this.props.exitToolName}(which isinline_chat_exit). As above, this tool is not one of the edit tools and can cause the model to exit without applying changes. Recommend rewording to “make all changes in a single edit-tool invocation” and keepinline_chat_exitonly for non-edit/exit paths.
}
Do not make code changes that are not directly and logically related to the user's prompt.<br />
ONLY change the `{filepath}` file, make all changes in a single invocation of the {this.props.exitToolName} tool, and change NO other file.
</Tag>
microsoft/vscode#289911 (comment)