Skip to content

Conversation

@ulugbekna
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 23, 2026 14:26
@ulugbekna ulugbekna self-assigned this Jan 23, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the codebase to sync with the latest VS Code sources, bringing in upstream improvements and API changes.

Changes:

  • Removed getIfExists from ServicesAccessor interface and updated all usages to use try-catch with get()
  • Improved type safety by replacing any with unknown throughout type guards and generic parameters
  • Refactored equals module with new *C suffix pattern for equality comparers, introducing IEquatable interface
  • Added new utility functions and features (normalization, throttle events, observable improvements)
  • Deleted nls.messages.ts and consolidated into nls.ts
  • Fixed bug in Range.isRange type guard where thing.end should be (<Range>thing).end

Reviewed changes

Copilot reviewed 64 out of 65 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/util/vs/platform/instantiation/common/instantiation.ts Removed getIfExists from ServicesAccessor interface
src/util/vs/platform/instantiation/common/instantiationService.ts Updated service accessor implementation to remove getIfExists method
src/platform/test/node/services.ts Updated TestingServicesAccessor to use try-catch instead of old getIfExists
test/simulation/inlineEdit/inlineEditTester.ts Replaced getIfExists with try-catch pattern
test/simulation/inlineEdit/inlineEditScoringService.ts Updated to use new thisEqualsC() instead of itemEquals()
src/extension/tools/test/node/virtualTools/virtualToolGrouping.spec.ts Added undefined check for groupBy result
src/extension/tools/common/virtualTools/virtualToolGrouper.ts Added type guard filter for groupBy results
src/extension/completions-core/vscode-node/lib/src/openai/test/fetch.test.ts Updated to use try-catch instead of getIfExists
src/util/vs/base/common/equals.ts Major refactoring: added IEquatable interface, new *C pattern for equality comparers
src/util/vs/base/common/collections.ts Changed groupBy return type to Partial<Record> for accuracy
src/util/vs/workbench/api/common/extHostTypes/range.ts Fixed bug: thing.end(<Range>thing).end in type guard
src/util/vs/workbench/api/common/extHostTypes/*.ts Improved type safety: anyunknown in type guards and toJSON methods
src/util/vs/base/common/normalization.ts New file: Unicode normalization utilities
src/util/vs/nls.messages.ts Deleted: consolidated into nls.ts
src/util/vs/nls.ts Consolidated NLS functions from deleted nls.messages.ts
src/util/vs/base/common/event.ts Added throttle event utility, improved defer/accumulate with flush options
src/util/vs/base/common/observableInternal/*.ts Multiple observable framework improvements and debug helpers
src/util/vs/base/common/*.ts Various utility improvements (strings, arrays, filters, glob, etc.)
src/util/vs/editor/common/core/*.ts Editor core improvements (TextEdit.compose, OffsetRange.withMargin, etc.)
src/util/vs/workbench/contrib/chat/common/promptSyntax/promptFileParser.ts Added prompt header attributes and image link filtering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants