fix(mcp): propagate abort signal to stop test execution #38939
+53
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an MCP tool call is aborted (e.g., user cancels in Claude Code), the abort signal from the MCP SDK was not being propagated to the test runner, causing tests to continue running even after the call was cancelled. This change: - Adds `signal: AbortSignal` parameter to `ServerBackend.callTool` - Passes `extra.signal` from MCP SDK request handler to backends - Listens for abort signal in `runTestsWithGlobalSetupAndPossiblePause` and calls `testRunner.stopTests()` when aborted - Updates all test tool handlers to accept and pass the signal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an MCP tool call is aborted (e.g., user cancels in Claude Code or another MCP client), the abort signal from the MCP SDK was not being propagated to the test runner, causing tests to continue running even after the call was cancelled.
This change:
signal: AbortSignalparameter toServerBackend.callToolextra.signalfrom MCP SDK request handler to backendsrunTestsWithGlobalSetupAndPossiblePauseand callstestRunner.stopTests()when abortedFixes #38937