feat(gen_ai): add function set_conversation_id and managing functions on the Scope and apply it on the Span on .finish()
#5362
Conversation
…ns on the Scope and apply it on the Span on `.finish()`
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
…same logic as in Relay
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
Nice! LGTM, see one comment
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| # Copy conversation_id from scope to span data if this is an AI span | ||
| conversation_id = scope.get_conversation_id() | ||
| if conversation_id: | ||
| has_ai_op = "gen_ai.operation.name" in self._data |
There was a problem hiding this comment.
Hardcoded string used instead of existing constant
Low Severity
The code uses a hardcoded string "gen_ai.operation.name" instead of the existing constant SPANDATA.GEN_AI_OPERATION_NAME. The SPANDATA import is already present (line 8), and other integrations like anthropic.py and google_genai/__init__.py use this constant. Using the constant would be more maintainable and consistent with the rest of the codebase.
Issues
Closes https://linear.app/getsentry/issue/TET-1736/python-sdk-add-gen-aiconversationid-to-the-integrations-where-it-is