Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

Partially addresses #677 by extending the model for issue location with sourceUrlLocationSchema.

  • Add sourceUrlLocationSchema
  • Create issueSourceSchema union type combining file and URL sources
  • Add type guards in the utils package
  • Update the Axe plugin to populate the source field with a URL, an HTML snippet, and a CSS selector
  • Update core and CI packages to handle the union type

Out of scope:

  • CLI upload: URL source data is not uploaded to the backend. The issueToGQL function includes source details only for file-based issues. Uploading URL sources requires Portal API changes first.
  • Portal API: Needs new fields to store URL-source data

Note

The selector is temporarily duplicated in the Axe issue message (e.g., [`img`] Fix this...) for Portal backward compatibility until it supports URL source display.

@hanna-skryl hanna-skryl self-assigned this Jan 24, 2026
@nx-cloud
Copy link

nx-cloud bot commented Jan 24, 2026

View your CI Pipeline Execution ↗ for commit b7380c7

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 32s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 13m 12s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 9s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-24 02:25:41 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 24, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1230

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1230

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1230

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1230

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1230

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1230

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1230

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1230

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1230

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1230

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1230

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1230

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1230

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1230

commit: b7380c7

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 1df6815 with previous commit d3230f1.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Security 🟡 51 🔴 47 ↓ −4.2
Performance 🔴 36 🔴 37 ↑ +0.3
Code coverage 🟢 92 🟢 92 ↓ −0.2
Documentation 🔴 42 🔴 42 ↑ +0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 100 🟢 100
Updates 🟡 78 🟡 78
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 2 groups improved, 👎 2 groups regressed, 👍 4 audits improved, 👎 8 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JS packages npm audit 🟡 51 🔴 47 ↓ −4.2
Lighthouse Performance 🔴 36 🔴 37 ↑ +0.3
Code coverage Code coverage metrics 🟢 92 🟢 92 ↓ −0.2
JSDocs coverage Documentation coverage 🔴 42 🔴 42 ↑ +0.1

30 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 600 ms 🟩 Root document took 530 ms ↓ −11.3 %
Lighthouse Speed Index 🟥 6.2 s 🟥 7.0 s ↑ +12.9 %
Lighthouse Total Blocking Time 🟥 2,080 ms 🟥 1,610 ms ↓ −22.6 %
JS packages Vulnerabilities for npm prod dependencies. 🟨 10 vulnerabilities (2 high, 1 moderate, 7 low) 🟨 11 vulnerabilities (2 high, 2 moderate, 7 low) ↑ +10 %
Lighthouse First Contentful Paint 🟥 3.0 s 🟥 3.1 s ↑ +1.2 %
Lighthouse Time to Interactive 🟥 13.3 s 🟥 13.4 s ↑ +0.9 %
JSDocs coverage Functions coverage 🟥 577 undocumented functions 🟥 578 undocumented functions ↑ +0.2 %
Code coverage Function coverage 🟩 94.3 % 🟩 94 % ↓ −0.3 %
JSDocs coverage Types coverage 🟥 268 undocumented types 🟥 272 undocumented types ↑ +1.5 %
JSDocs coverage Variables coverage 🟥 268 undocumented variables 🟥 272 undocumented variables ↑ +1.5 %
Code coverage Branch coverage 🟨 89 % 🟨 89 % ↓ −0.1 %
Code coverage Line coverage 🟩 92.3 % 🟩 92.3 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,104 KiB 🟩 Total size was 2,092 KiB ↓ −0.6 %
Lighthouse Minimizes main-thread work 🟥 9.7 s 🟥 11.4 s ↑ +17.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 226 KiB 🟥 Potential savings of 226 KiB ↓ −22.8 %
Lighthouse Largest Contentful Paint 🟥 11.5 s 🟥 11.7 s ↑ +2.5 %
Lighthouse Server Backend Latencies 🟩 690 ms 🟩 900 ms ↑ +30.6 %
Lighthouse Max Potential First Input Delay 🟥 990 ms 🟥 1,190 ms ↑ +20.3 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 83 KiB 🟥 Potential savings of 88 KiB ↓ −33.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +0.9 %
Lighthouse JavaScript execution time 🟥 4.5 s 🟥 4.6 s ↑ +2.1 %
Lighthouse Network Round Trip Times 🟩 0 ms 🟩 20 ms ↑ +345.5 %
Lighthouse Avoids an excessive DOM size 🟥 2,403 elements 🟥 2,390 elements ↓ −0.5 %
JS packages Outdated npm dev dependencies. 🟨 56 outdated package versions (29 major, 19 minor, 8 patch) 🟨 62 outdated package versions (29 major, 25 minor, 8 patch) ↑ +10.7 %
JS packages Vulnerabilities for npm dev dependencies. 🟥 43 vulnerabilities (3 critical, 23 high, 8 moderate, 9 low) 🟥 47 vulnerabilities (3 critical, 10 high, 31 moderate, 3 low) ↑ +9.3 %
JS packages Outdated npm prod dependencies. 🟨 15 outdated package versions (5 major, 8 minor, 2 patch) 🟨 18 outdated package versions (5 major, 11 minor, 2 patch) ↑ +20 %

652 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 1df6815 with previous commit d3230f1.

💼 Project utils

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 95 🟢 95 ↓ −0.5
Documentation 🔴 45 🔴 46 ↑ +0.3

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 3 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 95 🟢 95 ↓ −0.5
JSDocs coverage Documentation coverage 🔴 45 🔴 46 ↑ +0.3

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Functions coverage 🟥 239 undocumented functions 🟥 240 undocumented functions ↑ +0.4 %
Code coverage Function coverage 🟩 96.2 % 🟩 95.5 % ↓ −0.8 %
Code coverage Line coverage 🟩 97.8 % 🟩 97.6 % ↓ −0.1 %
Code coverage Branch coverage 🟩 91.8 % 🟩 91.7 % ↓ −0.1 %

440 other audits are unchanged.

💼 Project plugin-axe

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 70 🟡 70 ↓ −0.2
Code coverage 🟢 94 🟢 94 ↑ +0.1

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 70 🟡 70 ↓ −0.2
Code coverage Code coverage metrics 🟢 94 🟢 94 ↑ +0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Functions coverage 🟨 12 undocumented functions 🟨 12 undocumented functions  +0 %
Code coverage Line coverage 🟨 72.7 % 🟨 73 % ↑ +0.4 %
Code coverage Branch coverage 🟨 89.9 % 🟩 90 % ↑ +0.1 %

440 other audits are unchanged.

💼 Project create-cli

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 96 🟢 96 ↓ −0.2

5 other categories are unchanged.

👎 1 group regressed, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 96 🟢 96 ↓ −0.2

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 88.2 % 🟨 87.5 % ↓ −0.8 %

443 other audits are unchanged.

💼 Project ci

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 92 🟢 92 ↓ −0.1

5 other categories are unchanged.

👎 1 group regressed, 👎 1 audit regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 92 🟢 92 ↓ −0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 83.6 % 🟨 83.6 % ↓ −0.1 %
Code coverage Line coverage 🟩 94.8 % 🟩 94.8 % ↑ +0.1 %

443 other audits are unchanged.

💼 Project models

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 66 🟡 66 ↓ −0.1
Code coverage 🟢 94 🟢 94 ↑ +0.1

2 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 1 audit regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 66 🟡 66 ↓ −0.1
Code coverage Code coverage metrics 🟢 94 🟢 94 ↑ +0.1

10 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Variables coverage 🟥 72 undocumented variables 🟥 76 undocumented variables ↑ +5.6 %
Code coverage Line coverage 🟩 99.4 % 🟩 99.4 % ↑ +0.1 %
JSDocs coverage Types coverage 🟥 53 undocumented types 🟥 57 undocumented types ↑ +7.5 %

434 other audits are unchanged.

💼 Project core

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 90 🟢 90 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟩 94.8 % 🟩 94.8 % ↑ +0.1 %

443 other audits are unchanged.


8 other projects are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants