Add HTTP/2 keep-alive PING policy. #606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@arturobernalg The change-set will likely need some work, but I am conceptually fine with it. @rschmitt Would you have any conceptual objections to the idea? |
arturobernalg
force-pushed
the
pingAck
branch
from
0d9a332 to
a80a98d
Compare
Emit PINGs on otherwise idle connections once SETTINGS are ACKed, and close the session if the peer does not ACK within the configured timeout.
arturobernalg
force-pushed
the
pingAck
branch
from
a80a98d to
6224ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an HTTP/2 keep-alive PING policy for long-lived idle connections. When enabled, the client sends PING frames once the SETTINGS handshake is complete and no streams are active, and fails the session if the peer does not respond with PING[ACK] within the configured timeout. Integration tests validate that the connection remains usable past idle with keep-alive enabled and closes on inactivity when disabled.