Skip to content

Conversation

@jose-blockchain
Copy link

Summary

Fixes issue #844 where multiline claude_args with Bash tools containing spaces were incorrectly parsed by the shell-quote parser, causing arguments to be split at spaces.

Changes

  1. Added detection logic to identify incorrectly parsed arguments (e.g., Bash(git without closing paren, or standalone command words after tool names)
  2. Added warning when incorrect parsing is detected, guiding users to quote values with spaces
  3. Updated documentation in migration guide to clarify quoting requirement for Bash tools with spaces
  4. Added tests to verify the fix works correctly and warnings are triggered appropriately

Testing

All existing tests pass, and new tests verify:

  • Quoted values with spaces parse correctly
  • Unquoted values without spaces work as before (no false warnings)
  • Warnings are triggered when incorrect parsing is detected

Solution

The fix detects common patterns of incorrect parsing and warns users. The proper solution (as mentioned in the issue) is to quote values with spaces, which now works correctly in both single-line and multiline YAML formats.

Fixes #844

@jose-blockchain
Copy link
Author

please review @chrislloyd @dougbarth @bhuga if worth it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change isn't needed, we shouldn't have a package lock file at all since we have bun.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Multiline claude_args with Bash tools containing spaces parsed incorrectly

2 participants