-
Notifications
You must be signed in to change notification settings - Fork 472
feat: add pr title matching #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6921a11 to
16f0989
Compare
16f0989 to
4c6fd80
Compare
|
hoping this can be merged soon :) |
|
Beautiful! I would like to see this as well! |
| } | ||
|
|
||
| export function getTitle(): string | undefined { | ||
| const pullRequest = github.context.payload.pull_request; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead use REST API (octokit) to get the title dynamically?
I think the github.context may be statically set upon workflow event trigger. This would lead to confusion about using an outdated PR title after it has changed without triggering a new CI event (eg. re-running the job that uses this action after editing the PR title).
|
Would love to see this feature! |
|
whats the status on this..? this seems very useful.. |
Description:
Adds an additional match configuration for any and all for matching PR titles.
If this PR is acceptable I can also add matching PR body content matching in the same way.
Related issue:
supersedes, closes #688
supersedes, closes #109
refs #55
closes #809
Check list: