-
Notifications
You must be signed in to change notification settings - Fork 0
🩹[Patch]: Test important file changes and rename Auto-Release to Release-GHRepository #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
64f6e27
e20bf0d
f8324b6
c62cc90
b3a8d40
51bc591
94da564
a2af56e
0387b5d
c7f8a84
be469e2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -39,7 +39,8 @@ | |||||||||||||
| value: ${{ jobs.Get-Settings.outputs.Settings }} | ||||||||||||||
|
|
||||||||||||||
| permissions: | ||||||||||||||
| contents: read # to checkout the repo | ||||||||||||||
| contents: read # to checkout the repo | ||||||||||||||
| pull-requests: write # to add labels to PRs | ||||||||||||||
|
|
||||||||||||||
| jobs: | ||||||||||||||
| Get-Settings: | ||||||||||||||
|
|
@@ -49,13 +50,13 @@ | |||||||||||||
| Settings: ${{ steps.Get-Settings.outputs.Settings }} | ||||||||||||||
| steps: | ||||||||||||||
| - name: Checkout Code | ||||||||||||||
| uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 | ||||||||||||||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||||||||||||||
| with: | ||||||||||||||
| persist-credentials: false | ||||||||||||||
| fetch-depth: 0 | ||||||||||||||
|
|
||||||||||||||
| - name: Get-Settings | ||||||||||||||
| uses: PSModule/Get-PSModuleSettings@28c1805d689dc5bfcfba7489e76c34a6d33d7da8 # v1.4.0 | ||||||||||||||
| uses: PSModule/Get-PSModuleSettings@feature/important-file-changes | ||||||||||||||
|
||||||||||||||
| uses: PSModule/Get-PSModuleSettings@feature/important-file-changes | |
| uses: PSModule/Get-PSModuleSettings@v1 |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action reference uses an unstable feature branch instead of a stable release version. Feature branches can be force-pushed, deleted, or change unexpectedly, which could break the workflow or introduce security risks. For production workflows, always pin to a specific commit SHA or semantic version tag for stability and security.
| uses: PSModule/Get-PSModuleSettings@feature/important-file-changes | |
| uses: PSModule/Get-PSModuleSettings@v1 |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action reference uses a feature branch (@feature/important-file-changes) instead of a commit SHA with a version tag. This is inconsistent with all other PSModule action references in the codebase, which use the pattern @ # . For example, line 34 in Auto-Release.yml uses 'PSModule/Release-GHRepository@88c70461c8f16cc09682005bcf3b7fca4dd8dc1a # v2.0.1'.
Using feature branches in production workflows is risky because:
- The branch can be force-pushed or deleted, breaking the workflow
- It makes it unclear which version is being used
- It prevents rollback to known-good versions
Consider using a commit SHA reference with a version tag comment for consistency and stability.
| uses: PSModule/Get-PSModuleSettings@feature/important-file-changes | |
| uses: PSModule/Get-PSModuleSettings@d34db33fd34db33fd34db33fd34db33fd34db33f # v1.0.0 |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -67,6 +67,13 @@ | |||||||||
| id-token: write # to verify the deployment originates from an appropriate source | ||||||||||
|
|
||||||||||
| jobs: | ||||||||||
| Debug: | ||||||||||
| name: Debug | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| steps: | ||||||||||
| - name: Debug | ||||||||||
| uses: PSModule/Debug@main | ||||||||||
Check warningCode scanning / CodeQL Unpinned tag for a non-immutable Action in workflow Medium
Unpinned 3rd party Action 'Process-PSModule' step
Uses Step Error loading related location Loading
|
||||||||||
| uses: PSModule/Debug@main | |
| uses: PSModule/Debug@v1 |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action reference uses a branch name (@main) instead of a commit SHA with a version tag. This is inconsistent with all other PSModule action references in the codebase except for the Get-PSModuleSettings action on line 59 of Get-Settings.yml. For example, line 34 in Auto-Release.yml uses 'PSModule/Release-GHRepository@88c70461c8f16cc09682005bcf3b7fca4dd8dc1a # v2.0.1'.
Using branch references in production workflows is risky because:
- The branch can be updated without notice, potentially introducing breaking changes
- It makes it difficult to track which version is being used
- It prevents reproducible builds
Consider using a commit SHA reference with a version tag comment for consistency and stability.
| uses: PSModule/Debug@main | |
| uses: PSModule/Debug@0000000000000000000000000000000000000000 # v1.0.0 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium