Unclear usage of overrideSignInActivity

[yuqizhou77]

overrideSignInActivity?: (
tokenExchangeResource?: TokenExchangeResource,
tokenPostResource?: TokenPostResource,
signInLink?: string
) => ActivityLike; in

teams.ts/packages/apps/src/contexts/activity.ts

Line 114 in fb646c4

overrideSignInActivity?: (

will lead user to believe that they cannot customize tokenExchangeResource, tokenPostResource and signInLink but can only process these values after receiving it.

Would be better if we could make it clear or adding some docs around it.

[aacebo]

@heyitsaamir this may be valuable feedback that we either need to rename this method or provide a more intuitive way to customize the signin method.

[heyitsaamir]

Hmm, the intention was for the user to use the values for tokenExchangeResource, tokenPostResource and signInLink, and simply to generate a card, or similar. If the dev is going to use their own resource links etc, then they don't need to use signIn() method at all.

@yuqizhou77 , what's your use case in terms of customization?

[yuqizhou77]

@heyitsaamir We have a template that uses a functionality provided in V1 before which is same as this sample in teams-ai repo. https://github.com/microsoft/teams-ai/blob/e0c2be376d9b8342b78d59f62db70adc43a21ba5/js/samples/05.authentication/d.teamsSSO-bot/src/index.ts#L71. In this way, user does not need to have an Azure bot for OAuth connection to exchange token to access Graph resources. Benefits: 1. Get rid of Azure when local debugging. 2. Some people may have doubts about token being saved in token store. Therefore we would like to have a smooth way to migrate such template.

Hmm, the intention was for the user to use the values for tokenExchangeResource, tokenPostResource and signInLink, and simply to generate a card, or similar. If the dev is going to use their own resource links etc, then they don't need to use signIn() method at all.

@yuqizhou77 , what's your use case in terms of customization?

[heyitsaamir]

@heyitsaamir We have a template that uses a functionality provided in V1 before which is same as this sample in teams-ai repo. https://github.com/microsoft/teams-ai/blob/e0c2be376d9b8342b78d59f62db70adc43a21ba5/js/samples/05.authentication/d.teamsSSO-bot/src/index.ts#L71. In this way, user does not need to have an Azure bot for OAuth connection to exchange token to access Graph resources. Benefits: 1. Get rid of Azure when local debugging. 2. Some people may have doubts about token being saved in token store. Therefore we would like to have a smooth way to migrate such template.

Hmm, the intention was for the user to use the values for tokenExchangeResource, tokenPostResource and signInLink, and simply to generate a card, or similar. If the dev is going to use their own resource links etc, then they don't need to use signIn() method at all.
@yuqizhou77 , what's your use case in terms of customization?

Thanks for the context @yuqizhou77 . Could you clarify why a user might not need an azure bot for auth connection to exchange token? What scenario is that useful for?

[yuqizhou77]

@heyitsaamir We have a template that uses a functionality provided in V1 before which is same as this sample in teams-ai repo. https://github.com/microsoft/teams-ai/blob/e0c2be376d9b8342b78d59f62db70adc43a21ba5/js/samples/05.authentication/d.teamsSSO-bot/src/index.ts#L71. In this way, user does not need to have an Azure bot for OAuth connection to exchange token to access Graph resources. Benefits: 1. Get rid of Azure when local debugging. 2. Some people may have doubts about token being saved in token store. Therefore we would like to have a smooth way to migrate such template.

Hmm, the intention was for the user to use the values for tokenExchangeResource, tokenPostResource and signInLink, and simply to generate a card, or similar. If the dev is going to use their own resource links etc, then they don't need to use signIn() method at all.
@yuqizhou77 , what's your use case in terms of customization?

Thanks for the context @yuqizhou77 . Could you clarify why a user might not need an azure bot for auth connection to exchange token? What scenario is that useful for?

1. Firstly, user does not need to have an azure account and subscription for local testing. 2. Some user have concerns about storing token in token service that they would prefer the local way.