From 3d8d9dfef6772c26912b02d899bafb68767b434a Mon Sep 17 00:00:00 2001
From: Charles Lyding <19598772+clydin@users.noreply.github.com>
Date: Fri, 23 Jan 2026 11:20:13 -0500
Subject: [PATCH] ci: update Windows CI jobs to use Node.js 24 for test
 execution

---
 .github/workflows/ci.yml     | 6 +++---
 .github/workflows/pr.yml     | 4 ++--
 MODULE.bazel                 | 2 +-
 tools/toolchains/BUILD.bazel | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index a497a0bcb4f1..83f6ef09488b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -113,8 +113,8 @@ jobs:
         run: |
           pnpm bazel build \
             --config=e2e \
-            //tests:e2e.webpack_node22 \
-            //tests:e2e.esbuild_node22 \
+            //tests:e2e.webpack_node24 \
+            //tests:e2e.esbuild_node24 \
             --platforms=tools:windows_x64
       - name: Store built Windows E2E tests
         uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
@@ -131,7 +131,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [22]
+        node: [24]
         subset: [esbuild, webpack]
         shard: [0, 1, 2, 3, 4, 5]
     runs-on: windows-2025
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
index a91f9c7c0639..e2af14040684 100644
--- a/.github/workflows/pr.yml
+++ b/.github/workflows/pr.yml
@@ -139,7 +139,7 @@ jobs:
         run: |
           pnpm bazel build \
             --config=e2e \
-            //tests:e2e.esbuild_node22 \
+            //tests:e2e.esbuild_node24 \
             --platforms=tools:windows_x64
       - name: Store built Windows E2E tests
         uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
@@ -167,7 +167,7 @@ jobs:
       - name: Run CLI E2E tests
         uses: ./.github/shared-actions/windows-bazel-test
         with:
-          test_target_name: e2e.esbuild_node22
+          test_target_name: e2e.esbuild_node24
         env:
           E2E_SHARD_TOTAL: 1
           TESTBRIDGE_TEST_ONLY: tests/basic/{build,rebuild,serve}.ts
diff --git a/MODULE.bazel b/MODULE.bazel
index 93801502967a..5890f81b68ca 100644
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -180,5 +180,5 @@ register_toolchains(
     "@devinfra//bazel/git-toolchain:git_macos_arm64_toolchain",
     "@devinfra//bazel/git-toolchain:git_windows_toolchain",
     "//tools/toolchains:dummy_cc_windows_no_exec_toolchain",
-    "//tools/toolchains:node22_windows_no_exec_toolchain",
+    "//tools/toolchains:node24_windows_no_exec_toolchain",
 )
diff --git a/tools/toolchains/BUILD.bazel b/tools/toolchains/BUILD.bazel
index 1abb54e5faa7..5895884b09be 100644
--- a/tools/toolchains/BUILD.bazel
+++ b/tools/toolchains/BUILD.bazel
@@ -3,13 +3,13 @@ load(":dummy_cc_toolchain.bzl", "dummy_cc_toolchain_config")
 
 # This is needed following https://github.com/bazel-contrib/rules_nodejs/pull/3859
 toolchain(
-    name = "node22_windows_no_exec_toolchain",
+    name = "node24_windows_no_exec_toolchain",
     exec_compatible_with = [],
     target_compatible_with = [
         "@platforms//os:windows",
         "@platforms//cpu:x86_64",
     ],
-    toolchain = "@node22_windows_amd64//:toolchain",
+    toolchain = "@node24_windows_amd64//:toolchain",
     toolchain_type = "@rules_nodejs//nodejs:toolchain_type",
 )